This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
JDK-8209968: Fix off by one error in image scale calculation #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugener
reviewed
Aug 26, 2018
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java
Outdated
Show resolved
Hide resolved
|
In addition to answering Eugene's comments, you have a white-space error in the newly-added test file (see the Travis build log). |
kevinrushforth
suggested changes
Aug 31, 2018
There was a problem hiding this comment.
In addition to the specific comments, you still have a white-space error (the newly added file as DOS line endings). From the failing Travis log I see this:
Checking for white space errors
...
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java :DOS:
Found 1 whitespace or executable issues
To correct, use
bash tools/scripts/checkWhiteSpace -F -x
Error in white space check
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java
Outdated
Show resolved
Hide resolved
hjohn
force-pushed
the
develop
branch
2 times, most recently
from
341c24f to
7de6fd6
Compare
eugener
approved these changes
Aug 31, 2018
kevinrushforth
suggested changes
Aug 31, 2018
modules/javafx.graphics/src/main/java/com/sun/javafx/iio/common/ImageTools.java
Outdated
Show resolved
Hide resolved
modules/javafx.graphics/src/test/java/test/com/sun/javafx/iio/common/ImageToolsTest.java
Outdated
Show resolved
Hide resolved
|
JBS bug: JDK-8209968 Since this is close to being ready to go in, can you send a review request email to [email protected] referencing the JBS bug and this pull request? That way others can see it and comment if they want. |
kevinrushforth
approved these changes
Sep 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #164.
Contains additional test for case when dimensions are computed with one of them set to 0, just to confirm that they're working correctly.